Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32135 )
Change subject: vboot: remove Kconfig option VBOOT_PHYSICAL_REC_SWITCH ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32135/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32135/1//COMMIT_MSG@10 PS1, Line 10: https://crrev.com/c/1545144
Just curious, as I don't really know vboot / deptcharge interactions.. […]
This isn't removing the feature from vboot, it's just changing which code tells vboot to enable the feature. vboot has two stages (firmware verification and kernel verification) that run at different times (coreboot only ever runs the firmware verification part and depthcharge runs the kernel verification part). This flag only affects kernel verification, so it really belongs in depthcharge (or in whatever other bootloader links vboot to run that part). The fact that this flag has been set in coreboot for now is a historical oddity that grew out of how vboot developed over the years... it makes more sense to set it where it is actually used, so that's what we're fixing here.