Attention is currently required from: Felix Singer. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49062 )
Change subject: mb/kontron/bsl6: Reorder selects alphabetically ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Grouping options by their usage or effect is subjective, I think.
I meant grouping things that obviously belong together, e.g. because they are defined in the same Kconfig file, but don't share a prefix. For instance the
EXCLUDE_NATIVE_SD_INTERFACE
here. I have no idea what it is about. From its position on the left hand side of the diff, I'd say it's soc/skylake/ related. Of course, this could be handled by better naming of options. But if you look at the SOC_INTEL_ COMMON_ prefix for instance, there are many places already where the prefix makes up most of the name. In a long select block, that makes things harder to find (manually), IMHO. Same with variables in program code btw., if one starts prefixing them, chances are high that variables with the same prefix get mixed up.
tl;dr I don't think there's a simple rule that could make everything perfect.
way more readable and it looks cleaner
And how is that ^ not subjective?
There is CB:51673 now. If that got integrated into Jenkins, it would kill my main argument against alphabetical ordering. I still don't see an argument for it, though. Maybe I just miss something, e.g. is everybody using editors where searching is hard?