Attention is currently required from: Frank Wu, John Su, Martin Roth, Furquan Shaikh, Kangheui Won, Isaac Lee, Chris Wang, Rob Barnes, chris wang, Peter Marheine.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51669 )
Change subject: mb/google/zork/vilboz: Adjust eDP PHY driving to improve WWAN noise
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/zork/variants/vilboz/variant.c:
https://review.coreboot.org/c/coreboot/+/51669/comment/196fe2b3_3a14b73f
PS2, Line 31: variant_override_edp_tuningset()
Because the return value of this function is not "yes" or "no", but 0~3 for different settings, you […]
We can change to case switch if needed or we can leave ==1 here and write some comment on it. WDYT?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51669
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8c78c85783d16f3afa1718a3bf41efe9eb121860
Gerrit-Change-Number: 51669
Gerrit-PatchSet: 4
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Isaac Lee
isaaclee@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: chris wang
Chris.Wang@amd.com
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Isaac Lee
isaaclee@google.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: chris wang
Chris.Wang@amd.com
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Mon, 22 Mar 2021 13:52:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: John Su
john_su@compal.corp-partner.google.com
Comment-In-Reply-To: Isaac Lee
isaaclee@google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment