Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33767 )
Change subject: src/soc/amd/picasso: Update UARTs
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33767/4/src/soc/amd/picasso/Kconfig
File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/33767/4/src/soc/amd/picasso/Kconfig...
PS4, Line 196: config CONSOLE_UART_BASE_ADDRESS
I know this pre-exists, but do we really need it? It looks like this is a redunant definition that c […]
It seems only used to create the SeaBIOS .config. It looks like SeaBIOS writes debug info before the tables are located. If I remove it, the payload wont build.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33767
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74579674544f0edd2c0e6c4963270b442668e62f
Gerrit-Change-Number: 33767
Gerrit-PatchSet: 4
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 22 Jul 2019 14:35:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment