Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Zhuohao Lee, Aaron Durbin, Karthik Ramasubramanian.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56515 )
Change subject: mb/google/brya: create dynamic power limits mechanism for thermal
......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/google/brya/variants/baseboard/ramstage.c:
https://review.coreboot.org/c/coreboot/+/56515/comment/68547b2c_26a2401a
PS5, Line 31: variant_update_power_limits
Ah, I see. Let's go with this for now.
Sure, Thank you.
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56515/comment/5750da5a_400ea2b2
PS1, Line 30: field THERMAL 15 17
: option POWER_LIMITS_282 0
: option POWER_LIMITS_482 1
: option POWER_LIMITS_682 2
: end
I think the FW_CONFIG bits aren't necessary for selecting power limits, if they can be done by CPU S […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56515
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86619516adeec13642f02ba7faf9fc4945ad774e
Gerrit-Change-Number: 56515
Gerrit-PatchSet: 6
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 30 Jul 2021 09:13:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Gerrit-MessageType: comment