[coreboot-gerrit] Change in coreboot[master]: device: Expose round()

[Jonathan Zhang (Code Review)]

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38727 )

Change subject: device: Expose round()
......................................................................

Patch Set 1:

(2 comments)

Thanks Julius for reviewing. I am going to abandon this patch accordingly.

https://review.coreboot.org/c/coreboot/+/38727/1/src/include/device/device.h 
File src/include/device/device.h:

https://review.coreboot.org/c/coreboot/+/38727/1/src/include/device/device.h... 
PS1, Line 330:  * @return Rounded up number.
> Isn't this just the same as ALIGN_UP(val, 1 << pow)? Why not just get rid of the custom function and […]

Thank you Julius. Makes total sense. I will do that and withdraw this patch.

https://review.coreboot.org/c/coreboot/+/38727/1/src/include/device/device.h... 
PS1, Line 332: resource_t round(resource_t val, unsigned long pow);
> This needs to be way better namespaced if you want it globally visible (e.g. […]

makes total sense.