Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32392 )
Change subject: src/Kconfig: increase heap size if using flattened image tree
......................................................................
Patch Set 3:
Patch Set 3:
So it sounds like we need a way to tie in the Kconfig to this allocation (if possible). Have you looked into various options?
In the old days of bounce buffers and non-relocatable ramstage on x86, it would have been fragile for payload to access back to ramstage program. If I read the source correctly, ramstage heap became part of the hand-of-buffer with FIT payloads. Do we really want to allow that?
I think lib/device_tree.c and lib/fit_payload.c should malloc() from a completely separate heap.
I'm not up on the details of this sharing. Is the region just referenced or is it reused for its own malloc implementation?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32392
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id17f25e94d97e937b0e9a9cee3dd1a8aef1d525d
Gerrit-Change-Number: 32392
Gerrit-PatchSet: 3
Gerrit-Owner: Marty E. Plummer
hanetzer@startmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marty E. Plummer
hanetzer@startmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 16 Sep 2019 15:23:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment