[coreboot-gerrit] Change in coreboot[master]: acpi: add a function to read a table and verify it

[ron minnich (Code Review)]

ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41388 )

Change subject: acpi: add a function to read a table and verify it
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41388/2/src/acpi/acpi.c 
File src/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/41388/2/src/acpi/acpi.c@268 
PS2, Line 268: 	file = acpi_read_table(CONFIG_CBFS_PREFIX "/madt.aml", "APIC");
> We do not want an unconditional path here of using cbfs. This should be guarded by a Kconfig.

which one? I mean which Kconfig?

This is the exact same code pattern that's elsewhere in the file, for dsdt and slic, not guarded either.

I don't see the problem. If the file is not there, this code won't have any effect. What am I missing?