Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33141 )
Change subject: mb/*/{x201,ms2290}/mainboard.c: Remove superfluous ramstage code ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/33141/2/src/mainboard/lenovo/x201/mainboard.... File src/mainboard/lenovo/x201/mainboard.c:
https://review.coreboot.org/#/c/33141/2/src/mainboard/lenovo/x201/mainboard.... PS2, Line 81: : : :
Aren't these needed? Maybe they should go to a more common place, though.
Done in the romstage
https://review.coreboot.org/#/c/33141/2/src/mainboard/lenovo/x201/mainboard.... PS2, Line 71: /* If we're resuming from suspend, blink suspend LED */ : if (acpi_is_wakeup_s3()) : ec_write(0x0c, 0xc7); This is done in _SST. could likely be removed too