[coreboot-gerrit] Change in coreboot[master]: mainboard: Add Lenovo ThinkPad T440p

[Iru Cai (vimacs) (Code Review)]

Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34359 )

Change subject: mainboard: Add Lenovo ThinkPad T440p
......................................................................

Patch Set 11:

(3 comments)

https://review.coreboot.org/c/coreboot/+/34359/10/Documentation/mainboard/le... 
File Documentation/mainboard/lenovo/t440p_all_flash_chips.jpg:

PS10:
> Minor: picture is rather blurry, mind retaking it? Thanks

Done

https://review.coreboot.org/c/coreboot/+/34359/10/src/mainboard/lenovo/t440p... 
File src/mainboard/lenovo/t440p/acpi_tables.c:

https://review.coreboot.org/c/coreboot/+/34359/10/src/mainboard/lenovo/t440p... 
PS10, Line 20: /* FIXME: check this function.  */
> Maybe drop the comment

All FIXMEs are removed

https://review.coreboot.org/c/coreboot/+/34359/10/src/mainboard/lenovo/t440p... 
PS10, Line 31: // the lid is open by default.
> Please be consistent with the comment style

Done