Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38620 )
Change subject: mb/google/volteer: add volteer mainboard initial support
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38620/8/src/mainboard/google/voltee...
File src/mainboard/google/volteer/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/38620/8/src/mainboard/google/voltee...
PS8, Line 16: Scope (_SB.PCI0)
: {
: Device (IPU0)
: {
: Name (_ADR, 0x00050000)
: Name (_DDN, "Camera and Imaging Subsystem")
: }
: }
This should not be added to mainboard. It should be in SoC. […]
This is already in soc folder. Refer https://review.coreboot.org/c/coreboot/+/38469 and https://review.coreboot.org/c/coreboot/+/37863
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38620
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03a13f3df4e819ab9cf63ad69867c807d2a1b651
Gerrit-Change-Number: 38620
Gerrit-PatchSet: 8
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 30 Jan 2020 02:05:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment