Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40298 )
Change subject: soc/amd/picasso: Notify PSP system is going to sleep state ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/40298/1/src/soc/amd/picasso/smihand... File src/soc/amd/picasso/smihandler.c:
https://review.coreboot.org/c/coreboot/+/40298/1/src/soc/amd/picasso/smihand... PS1, Line 148: slptyp nit: code below uses `slp_typ`, maybe use it here for consistency?
https://review.coreboot.org/c/coreboot/+/40298/1/src/soc/amd/picasso/smihand... PS1, Line 152: switch (slptyp) { Given that `ACPI_Sx == x`, this looks odd. Is it intentional?