Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76211?usp=email )
Change subject: mb/google/rex/var/ovis: Configure GPP_V12 PAD ......................................................................
mb/google/rex/var/ovis: Configure GPP_V12 PAD
This patch configures GPP_V12 aka SOC_SLP_LAN_L properly as per the Ovis schematics dated June'23 to ensure LAN port is not in sleep.
BUG=b:289395519 TEST=Able to measure SLP_LAN PIN and confirm it's deasserted.
Change-Id: I1fe8715862823149c8a1f05e3e4463a615fbbbce Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/76211 Reviewed-by: Kapil Porwal kapilporwal@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/rex/variants/ovis/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Kapil Porwal: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/google/rex/variants/ovis/gpio.c b/src/mainboard/google/rex/variants/ovis/gpio.c index 3af1985..26e77f5 100644 --- a/src/mainboard/google/rex/variants/ovis/gpio.c +++ b/src/mainboard/google/rex/variants/ovis/gpio.c @@ -366,7 +366,7 @@ /* GPP_V11 : [] ==> SOC_GPP_V11 */ PAD_NC(GPP_V11, NONE), /* GPP_V12 : [] ==> SOC_SLP_LAN_L */ - PAD_CFG_NF(GPP_F17, NONE, DEEP, NF8), + PAD_CFG_NF(GPP_V12, NONE, DEEP, NF1), /* GPP_V14 : [] ==> SOC_WAKE_L */ PAD_NC(GPP_V14, NONE), /* GPP_V22 : [] ==> WCAM_RST_L */