Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32414 )
Change subject: x86: Implement RESET_VECTOR_IN_DRAM option
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/32414/14//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/32414/14//COMMIT_MSG@21
PS14, Line 21: begin executing it at reset.
Almost off-topic: If PSP shall run VBOOT, what is you plan about the toolchain used to build it? Proprietary or coreboot reference, or you throw the sources to AMD and get a signed blob back in return?
From GPL compliance guide:
Therefore, if you choose not to distribute the compiler, you should include a readme about where you got it, what version it was, and who to contact to acquire it, regardless of whether your compiler is FOSS, proprietary, or internally developed.
So, if you were to prepare coreboot toolchain anyways for verstage in PSP, I thought it would make sense to adapt rmodule loader such that PSP loads romstage as an rmodule.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32414
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I678b1f74546ea30abcc655a0daed795d6cfa0034
Gerrit-Change-Number: 32414
Gerrit-PatchSet: 14
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Edward O'Callaghan
quasisec@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Thu, 22 Aug 2019 11:18:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment