build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39971 )
Change subject: security/vboot: Provide stub functions for TPM in bootblock ......................................................................
Patch Set 1:
(8 comments)
https://review.coreboot.org/c/coreboot/+/39971/1/src/drivers/crb/tis.c File src/drivers/crb/tis.c:
https://review.coreboot.org/c/coreboot/+/39971/1/src/drivers/crb/tis.c@89 PS1, Line 89: if (ENV_BOOTBLOCK && !CONFIG(TPM_IN_BOOTBLOCK)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/39971/1/src/drivers/crb/tis.c@108 PS1, Line 108: if (ENV_BOOTBLOCK && !CONFIG(TPM_IN_BOOTBLOCK)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/39971/1/src/drivers/i2c/tpm/tis.c File src/drivers/i2c/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/39971/1/src/drivers/i2c/tpm/tis.c@7... PS1, Line 74: if (ENV_BOOTBLOCK && !CONFIG(TPM_IN_BOOTBLOCK)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/39971/1/src/drivers/i2c/tpm/tis.c@1... PS1, Line 148: if (ENV_BOOTBLOCK && !CONFIG(TPM_IN_BOOTBLOCK)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/39971/1/src/drivers/i2c/tpm/tis_atm... File src/drivers/i2c/tpm/tis_atmel.c:
https://review.coreboot.org/c/coreboot/+/39971/1/src/drivers/i2c/tpm/tis_atm... PS1, Line 62: if (ENV_BOOTBLOCK && !CONFIG(TPM_IN_BOOTBLOCK)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/39971/1/src/drivers/pc80/tpm/tis.c File src/drivers/pc80/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/39971/1/src/drivers/pc80/tpm/tis.c@... PS1, Line 638: if (ENV_BOOTBLOCK && !CONFIG(TPM_IN_BOOTBLOCK)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/39971/1/src/drivers/pc80/tpm/tis.c@... PS1, Line 659: if (ENV_BOOTBLOCK && !CONFIG(TPM_IN_BOOTBLOCK)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/39971/1/src/drivers/spi/tpm/tis.c File src/drivers/spi/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/39971/1/src/drivers/spi/tpm/tis.c@9... PS1, Line 96: if (ENV_BOOTBLOCK && !CONFIG(TPM_IN_BOOTBLOCK)) { braces {} are not necessary for single statement blocks