[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block/lpc: Include correct acpi.h

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48251 )

Change subject: soc/intel/common/block/lpc: Include correct acpi.h
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48251/3/src/soc/intel/common/block/... 
File src/soc/intel/common/block/lpc/lpc.c:

https://review.coreboot.org/c/coreboot/+/48251/3/src/soc/intel/common/block/... 
PS3, Line 14: <soc/acpi.h>
> Yes, that is the problem. It should pick up the soc/*/include/soc/acpi. […]

I know it's not the best, but would it make sense to drop the redundant declarations in skylake SoC and make it use intelblocks/acpi.h? Not sure if that breaks more things. Ideally, skylake should be moved to enable SOC_INTEL_COMMON_BLOCK_ACPI. But, as a quick fix, I think pushing the change in a particular SoC might be better than adding #ifdefs in common block code.