Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40545 )
Change subject: arch/x86/smbios: Add SMBIOS type8 data ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/40545/3/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/40545/3/src/arch/x86/smbios.c@918 PS3, Line 918: smbios_add_string(t->eos, port->external_reference_designator);
smbios_add_string function would increase the start value according to last pointer. […]
Ack
https://review.coreboot.org/c/coreboot/+/40545/3/src/include/smbios.h File src/include/smbios.h:
https://review.coreboot.org/c/coreboot/+/40545/3/src/include/smbios.h@583 PS3, Line 583: uint8_t port_type;
It looks good, but I don't know why they have error here. I've updated it again.
Ack