Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69576 )
(
4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soc/intel/meteorlake: Hide PMC and IOM devices ......................................................................
soc/intel/meteorlake: Hide PMC and IOM devices
Hide these ACPI device so Windows does not warn about missing device drivers.
Port of commit 907c85ad48dd ("soc/intel/alderlake: Hide PMC and IOM devices").
BUG=none TEST=Verified _STA method from ACPI tables in OS. USB-C drive is detected in OS.
Signed-off-by: Kapil Porwal kapilporwal@google.com Change-Id: Ic62172bee9120d260a3cd60770ef780cb7dce860 Reviewed-on: https://review.coreboot.org/c/coreboot/+/69576 Reviewed-by: Tarun Tuli taruntuli@google.com Reviewed-by: Subrata Banik subratabanik@google.com Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/meteorlake/acpi/tcss.asl M src/soc/intel/meteorlake/pmc.c 2 files changed, 29 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Eric Lai: Looks good to me, approved Tarun Tuli: Looks good to me, approved
diff --git a/src/soc/intel/meteorlake/acpi/tcss.asl b/src/soc/intel/meteorlake/acpi/tcss.asl index c2212f0..817afdd 100644 --- a/src/soc/intel/meteorlake/acpi/tcss.asl +++ b/src/soc/intel/meteorlake/acpi/tcss.asl @@ -327,6 +327,8 @@ IOM_BASE_ADDR, IOM_BASE_ADDR_MAX, 0x0, IOM_BASE_SIZE,,,) }) + /* Hide the device so that Windows does not complain on missing driver */ + Name (_STA, 0xB) }
/* diff --git a/src/soc/intel/meteorlake/pmc.c b/src/soc/intel/meteorlake/pmc.c index dbfc4be..bdd7a3b 100644 --- a/src/soc/intel/meteorlake/pmc.c +++ b/src/soc/intel/meteorlake/pmc.c @@ -103,6 +103,8 @@
acpigen_write_name_string("_HID", PMC_HID); acpigen_write_name_string("_DDN", "Intel(R) Meteor Lake IPC Controller"); + /* Hide the device so that Windows does not complain on missing driver */ + acpigen_write_STA(ACPI_STATUS_DEVICE_HIDDEN_ON);
/* * Part of the PCH's reserved 32 MB MMIO range (0xFC800000 - 0xFE7FFFFF).