Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36654 )
Change subject: libpayload: keyboard: Ignore special keys
......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36654/13/payloads/libpayload/driver...
File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/36654/13/payloads/libpayload/driver...
PS13, Line 249: if (media_key_mapping_callback != NULL) {
: if (ch == MEDIA_KEY_PREFIX) {
nit: this could be a single statement
https://review.coreboot.org/c/coreboot/+/36654/13/payloads/libpayload/driver...
PS13, Line 252: ret = media_key_mapping_callback(ch);
: return ret;
nit: return media_key_mapping_callback(ch);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36654
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c11939d18391bebe53ca21cf33a096ba369cd56
Gerrit-Change-Number: 36654
Gerrit-PatchSet: 13
Gerrit-Owner: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 14 Nov 2019 13:30:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment