Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44703 )
Change subject: soc/mediatek/mt8192: Do EMI init before dram calibration ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44703/2/src/soc/mediatek/mt8192/emi... File src/soc/mediatek/mt8192/emi.c:
https://review.coreboot.org/c/coreboot/+/44703/2/src/soc/mediatek/mt8192/emi... PS2, Line 301: emi_mdl_init
why move to this change?
Because we want each patch to be "functional".
Clearly CB:44699 needs to be merged before this patch. However, if CB:44699 is merged without this one, the emi_mdl_init() in the header will become unnecessary. Therefore, we can think of CB:44699 and this one as co-dependent patches, which should be merged into one.
https://review.coreboot.org/c/coreboot/+/44703/2/src/soc/mediatek/mt8192/emi... PS2, Line 374: 2
Will we have emi_init() for mt8192 as well?