27 Mar
2020
27 Mar
'20
6:32 p.m.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32549 )
Change subject: SKL: Add ACPI brightness control ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/32549/5/src/soc/intel/skylake/graph... File src/soc/intel/skylake/graphics.c:
https://review.coreboot.org/c/coreboot/+/32549/5/src/soc/intel/skylake/graph... PS5, Line 128: 0x2
The `dev` here should be the same as the `dev` passed to […]
Device 2 on the System Agent is iGFX. Perhaps "SA_DEV_IGD" from pci_devs.h could be used, but device number doesn't seem to vary, as Tigerlake (the latest architecture at this time in the tree?) uses the same number.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32549
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I993770fdcd0a28cee756df2bd6a795498f175952
Gerrit-Change-Number: 32549
Gerrit-PatchSet: 5
Gerrit-Owner: Matthew Garrett mjg59@google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Matthew Garrett mjg59@google.com
Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Fri, 27 Mar 2020 18:32:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment