Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45732 )
Change subject: mb/google/dedede: update devicetree for Boten ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45732/9/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/45732/9/src/mainboard/google/dedede... PS9, Line 5: select DRIVERS_GENERIC_GPIO_KEYS This specific change need to be part of a separate CL. No PEN devices are added in the device tree.
https://review.coreboot.org/c/coreboot/+/45732/9/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/gpio.c:
https://review.coreboot.org/c/coreboot/+/45732/9/src/mainboard/google/dedede... PS9, Line 11: PAD_CFG_GPI_SCI(GPP_C12, NONE, DEEP, EDGE_SINGLE, NONE), This specific change need to be part of a separate CL. No PEN devices are added in the device tree.