Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34802 )
Change subject: ifdtool: Add validate option to ifdtool ......................................................................
Patch Set 4:
Hello Mathew,
usually I'm asked to write documentation, but now I'm the one that actually misses some information. I know it is common for chromium firmware to have rendundant FMAP entries for the descriptor regions. But, AFAICS, this is nowhere documented. Especially the reason for these entries would be nice to know, as coreboot it- self doesn't care about them. Oh, and what does the SI prefix stand for?
Without such documentation, a validation option can be confusing. For instance, if I were told to imple- ment such an option in ifdtool, I would rather check that all FMAP regions are within the IFD BIOS region, because I wouldn't expect redundancy.