Attention is currently required from: Patrick Rudolph.
Julius Werner has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/87114?usp=email )
Change subject: drivers/smmstore: Support 64-bit MMIO addresses ......................................................................
Patch Set 1:
(1 comment)
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/87114/comment/0c46192d_255ebddf?usp... : PS1, Line 548: uint64_t mmap_addr_high; /* When the ROM MMIO address is above 4GiB the 'mmap_addr' cannot hold it. The naming here seems very confusing to me. When I see two fields `mmap_addr` and a later added `mmap_addr_high`, I'd expect that you want me to do `mmap_addr_high << 32 | mmap_addr`, but that's not how you designed it. How about renaming `mmap_addr` to `deprecated_mmap_addr` and naming the other one `mmap_addr_v2` or something like that?