[coreboot-gerrit] [L] Change in coreboot[main]: util/nvmtool: set Intel Gbe MAC addresses/checksum

[Michał Kopeć (Code Review)]

Attention is currently required from: Leah Rowe.

Michał Kopeć has posted comments on this change by Leah Rowe. ( https://review.coreboot.org/c/coreboot/+/67129?usp=email )

Change subject: util/nvmtool: set Intel Gbe MAC addresses/checksum
......................................................................

Patch Set 5: Code-Review+1

(1 comment)

File Documentation/util/nvmtool/index.md:

https://review.coreboot.org/c/coreboot/+/67129/comment/af102c21_fbfaa427?usp... :
PS5, Line 75: This software *may* work with IFDv2 systems, if the GbE NVM data structure
I've successfully tested this on a Meteor Lake platform (Clevo V540TU), seems to work well without issues. One thing of note, is that a clean, unpopulated GbE blob there only has part 0 populated, part 1 is all 0xFFs, so I needed to run `nvm copy 0` before setting the MAC. Not sure if that's also the case for other platforms.