Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47559 )
Change subject: intel/fsp2_0: Add soc_validate_fsp_version for FSP version check
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47559/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47559/1//COMMIT_MSG@10
PS1, Line 10: the console is usually ready.
In addition, we need to have weak function of getting FSP version. For instance, for CPX-SP FSP, the FSP version should change from 2.1-0.2.1.45 to 2.1-0.2.1-0.45 (adding a year field, year 2020 is year 0 for CPX-SP FSP).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47559
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I628014e05bd567462f50af2633fbf48f3dc412bc
Gerrit-Change-Number: 47559
Gerrit-PatchSet: 2
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Aaron Durbin
adurbin@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Isaac W Oram
isaac.w.oram@intel.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 14 Nov 2020 16:59:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment