Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37601 )
Change subject: mb/lenovo/t530/*/*/devicetree: Align whitespace and comments across the boards ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37601/9/src/mainboard/lenovo/t530/v... File src/mainboard/lenovo/t530/variants/w530/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37601/9/src/mainboard/lenovo/t530/v... PS9, Line 60: # Enable SATA ports 0 (HDD bay) & 1 (ODD bay) & 2 (mSATA) & 3 (eSATA) & 4 (dock)
That is not true
Done. Removed this comment from both boards' devicetrees.
https://review.coreboot.org/c/coreboot/+/37601/9/src/mainboard/lenovo/t530/v... PS9, Line 77: 0x4000201
I'd keep the full 8 nibbles, it's too easy to mistake a 7-nibble hex number as a full 8-nibble.
Agree. This looks better