Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42088 )
Change subject: soc/amd/picasso/bootblock: Write EIP to secure S3 ......................................................................
Uploaded patch set 6.
(5 comments)
https://review.coreboot.org/c/coreboot/+/42088/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42088/5//COMMIT_MSG@22 PS5, Line 22: One
Once
Done
https://review.coreboot.org/c/coreboot/+/42088/5//COMMIT_MSG@23 PS5, Line 23: remove
Maybe "consider removing"? We may just want to keep it so that we don't need to rely on the good gr […]
Done
https://review.coreboot.org/c/coreboot/+/42088/5/src/soc/amd/picasso/bootblo... File src/soc/amd/picasso/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/42088/5/src/soc/amd/picasso/bootblo... PS5, Line 15: #include <stdbool.h>
I believe this can go away now.
Done
https://review.coreboot.org/c/coreboot/+/42088/5/src/soc/amd/picasso/bootblo... PS5, Line 102: */
This comment ending should go on the next line
Done
https://review.coreboot.org/c/coreboot/+/42088/5/src/soc/amd/picasso/bootblo... PS5, Line 110: set_caching();
Oh, I understand now. […]
Done. I had it before so we could have as pristine state as possible.