Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34748 )
Change subject: amd/stoneyridge: Unify SMM relocation ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34748/3/src/soc/amd/stoneyridge/cpu... File src/soc/amd/stoneyridge/cpu.c:
https://review.coreboot.org/c/coreboot/+/34748/3/src/soc/amd/stoneyridge/cpu... PS3, Line 69: params->tseg_base.lo = ALIGN_DOWN(tseg_base, 128 * KiB); I don't like the impression here that tseg_base programmed to SMMR could potentially be different from what smm_region() returned. I'll probably have an assert in smm_subregion() for the alignments with further work anyways and might remove ALIGN_DOWN() here.
https://review.coreboot.org/c/coreboot/+/34748/3/src/soc/amd/stoneyridge/cpu... PS3, Line 80: Setting up SMI for CPU
Does not match function name... […]
That's the verbatim text accepted/used for late soc/intel. Indeed, it is borderline correct but I would just change them all at once at a later date.