Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon documentation and images ......................................................................
Patch Set 4:
(16 comments)
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/Padmelon.md:
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... PS1, Line 20: The picture was extracted from manual, however, the numbering on the padmelon board is misplaced.
Ok. Will fix, but also change the text as I'll take my own pictures.
Done
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... PS1, Line 40: no, use dediprog
I'm not sure, as I copied some of it from a board that looked like having very complete documentatio […]
Done
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... File Documentation/mainboard/amd/Padmelon.md:
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 20: The picture was extracted from manual, however, the numbering on the padmelon board is misplaced.
Picture will be replaced by one I myself will take.
Done
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 26: dediprog is protected from harm (even if still connected to the header) because the mux will float
Will do.
Done
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 31: +---------------------+--------------------+
will do.
Done
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 40: | In circuit flashing | no, use dediprog |
No, there's a header. The text (both sides) will be replaced with something more obvious.
Done
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/mainboard/amd... PS3, Line 59: padmelon
Will do.
Done
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon.jpg:
PS1:
Will take my own picture. Might need help labeling.
Done
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon_components.jpg:
PS1:
Will do.
Done
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon_io.jpg:
PS1:
Will do.
Done
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon_io_description.jpg:
PS1:
Will do.
Done
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/index... File Documentation/soc/amd/index.md:
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/index... PS1, Line 5: ## Technology
Sure
Done: 34561
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... File Documentation/soc/amd/merlinfalcon.md:
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... PS1, Line 14: <sup>1</sup>
Not anymore... I copied from family 177h and adapted, and did not noticed this reference... […]
Moved to 34561 and solved there.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... PS1, Line 19: <sup>TM</sup>
Again, copied from family 17h (which uses AGESA v9). […]
Moved to 34561 and replaced with _**TM**_
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... PS1, Line 27: <sup>R</sup>
Again, I don't know. I would assume so from a legal stand point.
Moved to 34561, but still present there.
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/soc/amd/merli... File Documentation/soc/amd/merlinfalcon.md:
https://review.coreboot.org/c/coreboot/+/34493/3/Documentation/soc/amd/merli... PS3, Line 14: specification<sup>1</sup>. coreboot relies on util/amdfwtool to build
Will remove it.
Moved to 34561 and removed there.