Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34939 )
Change subject: Add new ENV_xxx definitions ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34939/5/src/cpu/Kconfig File src/cpu/Kconfig:
https://review.coreboot.org/c/coreboot/+/34939/5/src/cpu/Kconfig@19 PS5, Line 19: default n Did this sneak in here? Add some comments on usage and meaning?
https://review.coreboot.org/c/coreboot/+/34939/5/src/include/rules.h File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/34939/5/src/include/rules.h@278 PS5, Line 278: #define ENV_HAS_DATA_SECTION ENV_PROGRAM_IN_RAM I think there are some platforms where .data is used. But my bigger question is how you envision tying this to ARCH_STAGE_HAS_DATA_SECTION ?
https://review.coreboot.org/c/coreboot/+/34939/5/src/include/rules.h@279 PS5, Line 279: #define ENV_HAS_BSS_SECTION !(ENV_ROMSTAGE && CONFIG(CAR_GLOBAL_MIGRATION)) And ARCH_STAGE_HAS_BSS_SECTION here.