build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41893 )
Change subject: soc/intel/common/block: Add new block DTT ......................................................................
Patch Set 1:
(16 comments)
https://review.coreboot.org/c/coreboot/+/41893/1/src/soc/intel/common/block/... File src/soc/intel/common/block/dtt/dtt.c:
https://review.coreboot.org/c/coreboot/+/41893/1/src/soc/intel/common/block/... PS1, Line 12: .read_resources = pci_dev_read_resources, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41893/1/src/soc/intel/common/block/... PS1, Line 12: .read_resources = pci_dev_read_resources, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/41893/1/src/soc/intel/common/block/... PS1, Line 13: .set_resources = pci_dev_set_resources, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41893/1/src/soc/intel/common/block/... PS1, Line 13: .set_resources = pci_dev_set_resources, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/41893/1/src/soc/intel/common/block/... PS1, Line 14: .enable_resources = pci_dev_enable_resources, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41893/1/src/soc/intel/common/block/... PS1, Line 14: .enable_resources = pci_dev_enable_resources, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/41893/1/src/soc/intel/common/block/... PS1, Line 15: .scan_bus = scan_generic_bus, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41893/1/src/soc/intel/common/block/... PS1, Line 15: .scan_bus = scan_generic_bus, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/41893/1/src/soc/intel/common/block/... PS1, Line 16: .ops_pci = &pci_dev_ops_pci, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41893/1/src/soc/intel/common/block/... PS1, Line 16: .ops_pci = &pci_dev_ops_pci, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/41893/1/src/soc/intel/common/block/... PS1, Line 20: .ops = &dptf_dev_ops, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41893/1/src/soc/intel/common/block/... PS1, Line 20: .ops = &dptf_dev_ops, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/41893/1/src/soc/intel/common/block/... PS1, Line 21: .vendor = PCI_VENDOR_ID_INTEL, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41893/1/src/soc/intel/common/block/... PS1, Line 21: .vendor = PCI_VENDOR_ID_INTEL, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/41893/1/src/soc/intel/common/block/... PS1, Line 22: .devices = pci_device_ids, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41893/1/src/soc/intel/common/block/... PS1, Line 22: .devices = pci_device_ids, please, no spaces at the start of a line