Hello Andrey Petrov, Patrick Rudolph, Łukasz Siudut, David Hendricks, Hung-Te Lin, Philipp Deppenwiese, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34501
to look at the new patch set (#2).
Change subject: Get HyperThreading setting from RW_VPD for FSP UPD ......................................................................
Get HyperThreading setting from RW_VPD for FSP UPD
Summary: This patch adds a library function in vpd_decode.h which is available in romstage, and thus can be used to customize FSP UPD setting.
Fetch key named as "HyperThreading" from RW_VPD which is a VPD partition. If there is a valid value, use the value to set FSP UPD HyperThreading variable.
If RW_VPD is not found, or if "HyperThreading" key does not exist, or if the value of "HyperThreading" key is neither '1' nor '0', default value is used.
BDW-DE SOC code is updated to use this function, if VPD is configured.
Test Plan: * Build an OCP MonoLake coreboot image, run following command to initialize RW_VPD and insert HyperThreading key: vpd -f build/coreboot.rom -O -i RW_VPD -s 'HyperThreading=0' * Flash the image to MonoLake, boot and observe following message in boot log: Detected 16 CPU threads
If RW_VPD partition does not exist, or if HyperThreading key/value pair does not exist, the boot log has: Detected 32 CPU threads
Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: Ice6ffe3f7a14c7f09637c5dcfc47e551a57f42f1 --- M src/drivers/vpd/vpd_decode.c M src/drivers/vpd/vpd_decode.h M src/soc/intel/fsp_broadwell_de/fsp/chipset_fsp_util.c 3 files changed, 105 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/34501/2