Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42849 )
Change subject: ACPI GNVS: Replace uses of smm_get_gnvs()
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42849/4/src/southbridge/intel/i8280...
File src/southbridge/intel/i82801ix/smihandler.c:
https://review.coreboot.org/c/coreboot/+/42849/4/src/southbridge/intel/i8280...
PS4, Line 39: gnvs = *(struct global_nvs **)0x500;
There was requeste to keep broken southbridge_update_gnvs() around until we have the proper fix around. The reference here forces qemu-q35 fix above.
https://review.coreboot.org/c/coreboot/+/42849/4/src/southbridge/intel/i8280...
PS4, Line 64: if (gnvs && gnvs->smif)
Followup handles qemu-q35 here with […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42849
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b657750b10f98524f011f5254e533217fe94fd8
Gerrit-Change-Number: 42849
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Jun 2020 08:30:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment