Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41809 )
Change subject: lib/coreboot_table: Add Intel FSP version to coreboot table
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41809/12/src/lib/coreboot_table.c
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/41809/12/src/lib/coreboot_table.c@3...
PS12, Line 37: #endif
Excuse my ignorance, but why not unconditionally include `fsp/util.h`? It looks like just for consistency with the current style in the file, but I believe we stopped guarding header inclusion.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41809
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92a13ca91b9f66a7517cfd6784f3f692ff34e765
Gerrit-Change-Number: 41809
Gerrit-PatchSet: 12
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 16 Jun 2020 09:02:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment