Attention is currently required from: Martin L Roth, Maximilian Brune, Patrick Georgi, Philipp Hug.
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81410?usp=email )
Change subject: arch/riscv: add Kconfig variable RISCV_HAS_MENVCFG ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81410/comment/92e62295_d70cdda8 : PS1, Line 10: Provide a Kconfig variable, default y, to enable it.
What happens if it's enabled but not present in the chip vs if it's present but disabled? Is this de […]
that's why it's not interactive. If it's enabled in the binary, but not enabled in the part, you'll get a fault. There are very few parts that do not have it IIUC, it went in a while ago.
The printf is a placeholder for hug's code.
You're right, it changes the binary, what am I thinking.
Patchset:
PS1:
Why wouldn't this change the binary? You're adding code. […]
yeah, you're right. I wonder if it's best to yank out the code change for now?
File src/arch/riscv/payload.c:
https://review.coreboot.org/c/coreboot/+/81410/comment/4e1e4f8f_acc006de : PS1, Line 72: part
Nit: Chip? SOC? […]
I like that. Done.