Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41392 )
Change subject: libpayload/cbgfx: Remove gap between adjacent boxes ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41392/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/c/coreboot/+/41392/1/payloads/libpayload/drivers... PS1, Line 82: while (d > INT32_MAX || d < INT32_MIN) {
new bits added on the left side are usually 0, but if the first operand is a signed negative value […]
Fine. coreboot and libpayload are written for GCC (and maybe clang which follows GCC on these things, although I think we dropped that support again for other issues). GCC implements arithmetic shifts as expected: https://gcc.gnu.org/onlinedocs/gcc-8.3.0/gcc/Integers-implementation.html#In...
We have plenty of code relying on GCC-specific extensions already, let's please not add a bunch of unnecessary complication here for this.