Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53926 )
Change subject: cpu/x86/smm: Fix typo
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/53926/comment/6dcfa8ed_66594e82
PS1, Line 7: cpu/x86/smm: Fix typo
Yes, but I like commit messages, where you do not need to look at the diff. […]
Specifying that the typo is in a comment lets people (e.g. reviewers) know that the change is supposed to not impact functionality. Some people like to describe one-line code changes as "typos", and these changes can sometimes have a huge impact.
Given that editing the commit message is very easy to do in Gerrit and preserves the review scores, I believe that disregarding Paul's suggestion was uncalled for. But it's too late now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/53926
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28f262078cf7f5ec4ed707639e845710a8cc56ea
Gerrit-Change-Number: 53926
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Comment-Date: Thu, 13 May 2021 08:31:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment