build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35118 )
Change subject: drivers/spi: add drivers for sdcard mounted on the spi bus
......................................................................
Patch Set 16:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35118/16/src/drivers/spi/spi_sdcard...
File src/drivers/spi/spi_sdcard.c:
https://review.coreboot.org/c/coreboot/+/35118/16/src/drivers/spi/spi_sdcard...
PS16, Line 392: if(!wait) {
space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/35118/16/src/drivers/spi/spi_sdcard...
PS16, Line 471: return -1; /* unknow card */
'unknow' may be misspelled - perhaps 'unknown'?
https://review.coreboot.org/c/coreboot/+/35118/16/src/drivers/spi/spi_sdcard...
PS16, Line 736:
trailing whitespace
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35118
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I464d2334b8227e448c1c7e324c0455023cffb72a
Gerrit-Change-Number: 35118
Gerrit-PatchSet: 16
Gerrit-Owner: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Shawn C
citypw@hardenedlinux.org
Gerrit-Reviewer: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 14 Nov 2019 06:27:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment