Attention is currently required from: Elyes Haouas, Felix Singer, Martin L Roth, Nick Vaccaro, Paul Menzel, Subrata Banik.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76719?usp=email )
Change subject: Revert "soc/intel/common/block/cse/Kconfig: Remove unused symbols"
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Please add a follow-up patch, adding such a configuration to `configs/`, so it gets build tested.
Sure, I'll do that.
File src/soc/intel/common/block/cse/Kconfig:
PS2:
These options are nowhere hooked up into the coreboot build system. […]
They're used in src/soc/intel/Makefile.inc:
```
$(call cse_add_file,cse_input_files,$(call cse_input_path,$(CONFIG_CSE_$(2)_FILE)),$(1),$(2))
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76719?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide6fc74b457439f06b7ef9b37f11d6c9ff226b80
Gerrit-Change-Number: 76719
Gerrit-PatchSet: 2
Gerrit-Owner: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Mon, 07 Aug 2023 22:44:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment
