David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38547 )
Change subject: device: Enumerate device based on IORESOURCE_ASSIGNED
......................................................................
Patch Set 9: Code-Review-1
(2 comments)
https://review.coreboot.org/c/coreboot/+/38547/6/src/device/device.c
File src/device/device.c:
https://review.coreboot.org/c/coreboot/+/38547/6/src/device/device.c@383
PS6, Line 383: /* Skip if IO resource was assigned */
Please elaborate both in comments as well as patch description the problem and solution for achievin […]
I'm not sure that changing compute_resources() is what we really want. This is just the first pass where the allocator is trying to figure out the topology so that it can assign resources in the second pass (allocate_resources()). Ignoring pre-assigned resources just means it won't have that info and can mess up in the second pass.
https://review.coreboot.org/c/coreboot/+/38547/6/src/device/device.c@498
PS6, Line 498:
I think this is where we'd want to skip pre-assigned resources:
if (resource->flags & IORESOURCE_ASSIGNED)
continue;
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38547
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69e100ea658fefec905321197b5bd6da1e0e647a
Gerrit-Change-Number: 38547
Gerrit-PatchSet: 9
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Andrey Petrov
anpetrov@fb.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 Jan 2020 02:20:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Gerrit-MessageType: comment