Attention is currently required from: Arthur Heymans, Philipp Hug, ron minnich.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81294?usp=email )
Change subject: arch/riscv: add new SBI calls
......................................................................
Patch Set 7:
(1 comment)
File src/arch/riscv/sbi.c:
https://review.coreboot.org/c/coreboot/+/81294/comment/514eaa99_1be6d203 :
PS3, Line 120: if (0) {
People tend to put in their own debugging prints if something goes south. I don't really like code in coreboot that never gets executed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81294?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5dac8613020e26ec74ac1c74158fc9791553693f
Gerrit-Change-Number: 81294
Gerrit-PatchSet: 7
Gerrit-Owner: ron minnich
rminnich@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 22 Mar 2024 12:56:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment