[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/braswell: Use common cpu/intel/car code

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32963 )

Change subject: soc/intel/braswell: Use common cpu/intel/car code
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/#/c/32963/5/src/drivers/intel/fsp1_1/cache_as_ra... 
File src/drivers/intel/fsp1_1/cache_as_ram.inc:

https://review.coreboot.org/#/c/32963/5/src/drivers/intel/fsp1_1/cache_as_ra... 
PS5, Line 93: 	addl	$4, %esp
This makes no sense?

https://review.coreboot.org/#/c/32963/5/src/drivers/intel/fsp1_1/cache_as_ra... 
PS5, Line 136: 	pushl	%edi	/* bist */
Use %ebx to backup BIST, you need %edi for stosl above.