T Michael Turney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27360 )
Change subject: sdm845: Add interface between CB & QCLib ......................................................................
Patch Set 35:
Patch Set 35:
(2 comments)
One comment from PS31 on 9.Nov.2018 is not addressed yet, regarding CONFIG_CBFS_PREFIX being part of #define for name, e.g. "/pmic". Please confirm, after reviewing latest patch that this is still desired change.
Yes, I still think that would be a bit cleaner.
After looking at how the whole codebase uses CONFIG_CBFS_PREFIX, this request would make sdm845 code different. In fact to fit in with the codebase, the #define for the name, e.g. pmic or aop should be removed...
./mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c:152: file_name = CONFIG_CBFS_PREFIX "/ssdt2.aml"; ./mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c:155: file_name = CONFIG_CBFS_PREFIX "/ssdt3.aml"; ./mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c:158: file_name = CONFIG_CBFS_PREFIX "/ssdt4.aml"; ./mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c:162: file_name = CONFIG_CBFS_PREFIX "/ssdt5.aml";
./arch/arm64/arm_tf.c:47: struct prog bl31 = PROG_INIT(PROG_BL31, CONFIG_CBFS_PREFIX"/bl31"); ./arch/arm64/arm_tf.c:61: CONFIG_CBFS_PREFIX"/secure_os");
./arch/x86/acpi.c:1143: CONFIG_CBFS_PREFIX "/dsdt.aml", ./arch/x86/acpi.c:1157: slic_file = cbfs_boot_map_with_leak(CONFIG_CBFS_PREFIX "/slic",
./arch/x86/postcar_loader.c:161: PROG_INIT(PROG_POSTCAR, CONFIG_CBFS_PREFIX "/postcar");
./security/vboot/vboot_loader.c:98: CONFIG_CBFS_PREFIX "/verstage"); ./security/vboot/vboot_crtm.c:57: PROG_INIT(PROG_VERSTAGE, CONFIG_CBFS_PREFIX "/verstage"); ./security/vboot/vboot_crtm.c:59: PROG_INIT(PROG_ROMSTAGE, CONFIG_CBFS_PREFIX "/romstage"); ./security/vboot/vboot_crtm.c:111: CONFIG_CBFS_PREFIX "/romstage"); ./security/vboot/vboot_crtm.c:134: CONFIG_CBFS_PREFIX "/verstage");
./lib/prog_loaders.c:56: PROG_INIT(PROG_ROMSTAGE, CONFIG_CBFS_PREFIX "/romstage"); ./lib/prog_loaders.c:129: PROG_INIT(PROG_RAMSTAGE, CONFIG_CBFS_PREFIX "/ramstage"); ./lib/prog_loaders.c:171: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/payload");
./lib/decompressor.c:29: ".incbin "" __BUILD_DIR__ "/cbfs/" CONFIG_CBFS_PREFIX "/bootblock.lz4"\n\t"
./soc/qualcomm/sdm845/aop_load_reset.c:31: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); ./soc/qualcomm/sdm845/qclib.c:30: size = cbfs_boot_load_file(CONFIG_CBFS_PREFIX PMIC_NAME, ./soc/qualcomm/sdm845/qclib.c:37: size = cbfs_boot_load_file(CONFIG_CBFS_PREFIX DCB_NAME, ./soc/qualcomm/common/qclib.c:164: PROG_INIT(PROG_REFCODE, CONFIG_CBFS_PREFIX QCSDI_NAME); ./soc/qualcomm/common/qclib.c:182: PROG_INIT(PROG_REFCODE, CONFIG_CBFS_PREFIX QCLIB_NAME);
./soc/intel/baytrail/refcode.c:47: PROG_INIT(PROG_REFCODE, CONFIG_CBFS_PREFIX "/refcode"); ./soc/intel/broadwell/refcode.c:44: PROG_INIT(PROG_REFCODE, CONFIG_CBFS_PREFIX "/refcode");