Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34106 )
Change subject: drivers/crb: Add CRB driver for TPM2 support
......................................................................
Patch Set 22: Code-Review+1
(2 comments)
Fix license headers to the coreboot default one
https://review.coreboot.org/c/coreboot/+/34106/22/src/drivers/crb/tis.c
File src/drivers/crb/tis.c:
https://review.coreboot.org/c/coreboot/+/34106/22/src/drivers/crb/tis.c@22
PS22, Line 22: {0x15d1, 0x001b, "SLB9670"},
remove
https://review.coreboot.org/c/coreboot/+/34106/22/src/drivers/crb/tis.c@114
PS22, Line 114:
Implement PPI and MCI, or we do it in a follow up
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34106
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I477e45963fe3cdbc02cda9ae99c19142747e4b46
Gerrit-Change-Number: 34106
Gerrit-PatchSet: 22
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 29 Jul 2019 11:34:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment