[coreboot-gerrit] Change in coreboot[master]: soc/intel: Fix regression with hidden PCI devices

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34285 )

Change subject: soc/intel: Fix regression with hidden PCI devices
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34285/7/src/device/device_const.c 
File src/device/device_const.c:

https://review.coreboot.org/c/coreboot/+/34285/7/src/device/device_const.c@2... 
PS7, Line 243: 	printk(BIOS_ERR, "BUG: %s requests hidden 00:%02x.%u\n", func, devfn >> 3, devfn & 7);
> It was in the static devicetree, but failing ID query it was removed from the topology links pcidev_ […]

Thanks for the description. I pieced it together when digging earlier as well as your clarifications on the mailing list.

They put in a decode filter for certain transaction types and addresses when the p2sb device is hidden. Moreover, there is a fabric id policy check as well, I think, but that comes into play when shedding privileges during boot.