build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31371 )
Change subject: [WIP] mAL10
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/31371/4/src/mainboard/kontron/mal10...
File src/mainboard/kontron/mal10/gpio.h:
https://review.coreboot.org/c/coreboot/+/31371/4/src/mainboard/kontron/mal10...
PS4, Line 71: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_172, DN_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* SDCARD_CLK */
line over 96 characters
https://review.coreboot.org/c/coreboot/+/31371/4/src/mainboard/kontron/mal10...
File src/mainboard/kontron/mal10/romstage.c:
https://review.coreboot.org/c/coreboot/+/31371/4/src/mainboard/kontron/mal10...
PS4, Line 7: void mainboard_memory_init_params(FSPM_UPD *const mupd)
need consistent spacing around '*' (ctx:WxV)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31371
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3d09e4eb23655825b7603f49f0bad31116ac6e1
Gerrit-Change-Number: 31371
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 22 Apr 2020 13:56:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment