Attention is currently required from: Raul Rangel, Furquan Shaikh.
Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52181 )
Change subject: mb/google/guybrush/var/guybrush: Add FPMCU configration
......................................................................
Patch Set 21:
(2 comments)
File src/mainboard/google/guybrush/variants/baseboard/helpers.c:
https://review.coreboot.org/c/coreboot/+/52181/comment/9fb30d0e_ea85cbf5
PS19, Line 14: }
Don't you want to find the UART peripheral? Having the controller enabled doesn't necessarily mean y […]
Thanks for review, done.
https://review.coreboot.org/c/coreboot/+/52181/comment/de5648af_826d9539
PS19, Line 17: mmio_dev->link_list
hrmm, dereferencing a NULL pointer... […]
Thanks for review, done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52181
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c56b0db193be6804d07c2f333445c2a1dbf9f59
Gerrit-Change-Number: 52181
Gerrit-PatchSet: 21
Gerrit-Owner: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Fri, 16 Apr 2021 02:52:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment