Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37829 )
Change subject: asus/am1i-a: Switch away from ROMCC_BOOTBLOCK
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37829/1/src/mainboard/asus/am1i-a/b...
File src/mainboard/asus/am1i-a/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37829/1/src/mainboard/asus/am1i-a/b...
PS1, Line 125: /* Disable PCI-PCI bridge and release GPIO32/33 for other uses. */
Didn't remove yet, need more info.
Ack
https://review.coreboot.org/c/coreboot/+/37829/1/src/mainboard/asus/am1i-a/b...
PS1, Line 150: * because of the buffer ICS551M
Didn't remove yet, need more info.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37829
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I780fa87cb9cb3c45844c388331ef89eb8eb70ebb
Gerrit-Change-Number: 37829
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 26 Dec 2019 08:07:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Mike Banon
mikebdp2@gmail.com
Gerrit-MessageType: comment