Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37680 )
Change subject: security/vboot: Ensure firmware body size is respected again
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37680/1/src/security/vboot/vboot_lo...
File src/security/vboot/vboot_logic.c:
https://review.coreboot.org/c/coreboot/+/37680/1/src/security/vboot/vboot_lo...
PS1, Line 200: region_device_sz
Should this be vb2api_get_firmware_size(ctx)?
With this patch, the rdev returned by vboot_locate_firmware() is already truncated. So region_device_sz(fw_body) will already be equal to vb2api_get_firmware_size() here, no need to call it again.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37680
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I167cd40cb435dbae7f09d6069c9f1ffc1d99fe13
Gerrit-Change-Number: 37680
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mathew King
mathewk@chromium.org
Gerrit-Comment-Date: Thu, 12 Dec 2019 22:18:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mathew King
mathewk@chromium.org
Gerrit-MessageType: comment